-
Notifications
You must be signed in to change notification settings - Fork 810
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
5098 branch 7 update invalid blob gas used params #7408
5098 branch 7 update invalid blob gas used params #7408
Conversation
Signed-off-by: Matilda Clerke <matilda.clerke@consensys.net>
…ion, apply spotless Signed-off-by: Matilda Clerke <matilda.clerke@consensys.net>
…ion, apply spotless Signed-off-by: Matilda Clerke <matilda.clerke@consensys.net>
Signed-off-by: Matilda Clerke <matilda.clerke@consensys.net>
Signed-off-by: Matilda Clerke <matilda.clerke@consensys.net>
Signed-off-by: Matilda Clerke <matilda.clerke@consensys.net>
…-branch-2-update-invalid-accounts-params
Signed-off-by: Matilda Clerke <matilda.clerke@consensys.net>
Signed-off-by: Matilda Clerke <matilda.clerke@consensys.net>
Signed-off-by: Matilda Clerke <matilda.clerke@consensys.net>
…' into 5098-branch-3-update-invalid-address-hash-params
Signed-off-by: Matilda Clerke <matilda.clerke@consensys.net>
Signed-off-by: Matilda Clerke <matilda.clerke@consensys.net>
…-branch-2-update-invalid-accounts-params
…' into 5098-branch-3-update-invalid-address-hash-params
Signed-off-by: Matilda Clerke <matilda.clerke@consensys.net>
Signed-off-by: Matilda Clerke <matilda.clerke@consensys.net>
…-branch-2-update-invalid-accounts-params
…' into 5098-branch-3-update-invalid-address-hash-params
Signed-off-by: Matilda Clerke <matilda.clerke@consensys.net>
Signed-off-by: Matilda Clerke <matilda.clerke@consensys.net>
…ounts-params' into 5098-branch-2-update-invalid-accounts-params
…' into 5098-branch-3-update-invalid-address-hash-params
…rams' into 5098-branch-4-update-invalid-address-params
Signed-off-by: Matilda Clerke <matilda.clerke@consensys.net>
…' into 5098-branch-3-update-invalid-address-hash-params
…rams' into 5098-branch-4-update-invalid-address-params
… into 5098-branch-5-update-invalid-auth-params
…to 5098-branch-6-update-invalid-blob-count
…o 5098-branch-7-update-invalid-blob-gas-used-params
Signed-off-by: Matilda Clerke <matilda.clerke@consensys.net>
Signed-off-by: Matilda Clerke <matilda.clerke@consensys.net>
…dJsonRpcParameters Signed-off-by: Matilda Clerke <matilda.clerke@consensys.net>
… into 5098-branch-5-update-invalid-auth-params
Signed-off-by: Matilda Clerke <matilda.clerke@consensys.net>
…to 5098-branch-6-update-invalid-blob-count
…o 5098-branch-7-update-invalid-blob-gas-used-params
… into 5098-branch-5-update-invalid-auth-params
…to 5098-branch-6-update-invalid-blob-count
…o 5098-branch-7-update-invalid-blob-gas-used-params
Signed-off-by: Matilda-Clerke <matilda.clerke@consensys.net>
…to 5098-branch-6-update-invalid-blob-count
…o 5098-branch-7-update-invalid-blob-gas-used-params
Signed-off-by: Matilda Clerke <matilda.clerke@consensys.net>
…to 5098-branch-6-update-invalid-blob-count
…o 5098-branch-7-update-invalid-blob-gas-used-params
RpcErrorType.INVALID_BLOB_GAS_USED_PARAMS, "Missing blob gas used field"); | ||
} else if (payloadParameter.getExcessBlobGas() == null) { | ||
return ValidationResult.invalid( | ||
RpcErrorType.INVALID_PARAMS, "non-null ExcessBlobGas pre-cancun"); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is there not a specific error code for this one?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is, but it will be coming in a later PR as I'm updating them in alphabetical order to ensure I don't miss any. This is the 7th PR in the series, breaking apart #7389 which is too gigantic to review.
* 5098: Add RpcErrorTypes Signed-off-by: Matilda Clerke <matilda.clerke@consensys.net> --------- Signed-off-by: Matilda Clerke <matilda.clerke@consensys.net> Signed-off-by: Matilda-Clerke <matilda.clerke@consensys.net> Co-authored-by: Sally MacFarlane <macfarla.github@gmail.com> Signed-off-by: gconnect <agatevureglory@gmail.com>
PR description
Update code to use RpcErrorType.INVALID_BLOB_GAS_USED_PARAMS
Fixed Issue(s)
#5098